This repository was archived by the owner on Mar 16, 2024. It is now read-only.
fix detection when AUTH_SECRET is empty#108
Open
cpainchaud wants to merge 1 commit intowfg:masterfrom
Open
Conversation
Owner
|
In which situations does the original test not work?
…On Tue, May 23, 2023 at 6:51 AM Christophe Painchaud < ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#108
Commit Summary
- ab55b1c
<ab55b1c>
fix detection when AUTH_SECRET is empty
File Changes
(1 file <https://github.com/wfg/docker-openvpn-client/pull/108/files>)
- *M* build/entry.sh
<https://github.com/wfg/docker-openvpn-client/pull/108/files#diff-39196f8f2c230c2083782ea5ad2a8ee20087a134d43a7d242bc33a60c1e47176>
(2)
Patch Links:
- https://github.com/wfg/docker-openvpn-client/pull/108.patch
- https://github.com/wfg/docker-openvpn-client/pull/108.diff
—
Reply to this email directly, view it on GitHub
<#108>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJCPA4BDECCLOJTZN5YCHLXHSQERANCNFSM6AAAAAAYLYULGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Author
|
If I put no AUTH_SECRET when I created the container (I put credentials in the opvn config file) then this test will fail and will force the use of --auth-user-pass" "/run/secrets/$AUTH_SECRET" which is obviously why this test was put in place I guess for the record this is how I create my container: |
Author
|
any new on this one @wfg ? thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.